Skip to content

Fix formatting of addresses passed to SCP#425

Merged
jujubot merged 1 commit intojuju:masterfrom
fnordahl:issue/424
Jun 16, 2020
Merged

Fix formatting of addresses passed to SCP#425
jujubot merged 1 commit intojuju:masterfrom
fnordahl:issue/424

Conversation

@fnordahl
Copy link
Copy Markdown
Contributor

@fnordahl fnordahl commented Jun 6, 2020

When using SCP to a machine with an IPv6 address the IPv6 address
must be encapsulated in brackets ('[]').

Fixes #424

When using SCP to a machine with an IPv6 address the IPv6 address
must be encapsulated in brackets ('[]').

Fixes juju#424
Copy link
Copy Markdown
Member

@SimonRichardson SimonRichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$$merge$$

@SimonRichardson
Copy link
Copy Markdown
Member

$$merge$$

@SimonRichardson
Copy link
Copy Markdown
Member

!!build!!

@SimonRichardson
Copy link
Copy Markdown
Member

$$merge$$

@jujubot jujubot merged commit 9493709 into juju:master Jun 16, 2020
@SimonRichardson
Copy link
Copy Markdown
Member

Finally! @fnordahl sorry it took so long.

@fnordahl
Copy link
Copy Markdown
Contributor Author

No worries, thank you for your persistence in getting it merged @SimonRichardson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scp_from/scp_to renders invalid address format when IPv6 is used

4 participants